Exactly!
However...
[youtube]http://www.youtube.com/watch?v=1D1cap6yETA[/youtube]
Good News, Everyone!
I think I've discovered the issue. I'll recompile and test, and then post again with the results!
OblivionGate Wrote:You'd never see this on a Blizzard server...
![[Image: 2uz6qfq.png]](http://i56.tinypic.com/2uz6qfq.png)
I don't think I've ever seen a "Conquest of the Horde is full" message on a blizzard server either, You're right, I haven't seen that message... They must not be as awesome as CotH... I wonder what CotH stands for...
True, but apparently the queue thing times you out after so long.
It had probably crashed again at that point!
*waits patiently, gets hungry, goes to make dinner.*
*burns the kitchen down.*
*decides it is better to accidentally burn the kitchen down then to stay on forums and accidentally agitate Kretol.*
Sorry, Kretol.
Woo! The error has been resolved!
The issue had to do with a code edit I did involving whispers.
Code:
if (!player || (tSecurity == SEC_PLAYER && pSecurity > SEC_PLAYER && !player->isAcceptWhispers()))
{
if (lang != LANG_ADDON)
SendPlayerNotFoundNotice(to);
return;
}
The
if (lang != LANG_ADDON) part was what I added. This prevents addons from spamming your screen with "That player is not online" if it's trying to communicate with folks that may have just logged off or the like. Unfortunately, when I was merging my edits into the new repository, I tried adding in some curly brackets like so:
Code:
if (!player || (tSecurity == SEC_PLAYER && pSecurity > SEC_PLAYER && !player->isAcceptWhispers()))
{
if (lang != LANG_ADDON)
{
SendPlayerNotFoundNotice(to);
return;
}
}
I had failed to realize that the return is necessary regardless of whether it's an addon or not. The crashes were being caused by people trying to send a whisper to someone not online (possibly from trying to reply to someone that had just logged off). So, rejoice!
I don't know what that means, Or what it is you're talking about. I would like to say Thank you for fixing whatever the problem was. I'm sure there are things you like to do with your spare time, and listening to impatient strangers can't be on the top five. Once again and always thank you for whatever it is you do, to keep this server running.
Odd .. those brackets look valid for C or Java - I wouldn't think it would matter.
Well, it's because there's no 'else' fallback. There's like three or four 'if' statements, which everyone should fall into. My presumption is that, for those whispers that were addon messages (I think it was the addons themselves that were causing it, not people trying to send a whisper to someone not online), the server didn't know what to do with them because it didn't fit into any of the 'if' statements.
I BLAME TALES.
Also, does that mean we should turn off our addons?
No, it's no longer a problem; that's why I was saying it was fixed! *nods sagely*